Add a new ref()->domElementNamespace() function#2516
Open
stloyd wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2516 +/- ##
============================================
- Coverage 85.97% 85.96% -0.02%
- Complexity 0 22258 +22258
============================================
Files 1662 1663 +1
Lines 68370 68406 +36
============================================
+ Hits 58784 58808 +24
- Misses 9586 9598 +12 🚀 New features to boost your workflow:
|
stloyd
commented
Jul 8, 2026
stloyd
commented
Jul 9, 2026
Comment on lines
+157
to
+161
| if ($this->value instanceof XMLDocument) { | ||
| $serialized = $this->value->saveXml($this->value->documentElement); | ||
| } else { | ||
| // @mago-ignore analysis:possibly-invalid-argument,possibly-invalid-argument | ||
| $serialized = $this->value->saveXML($this->value->documentElement); |
Member
Author
There was a problem hiding this comment.
Mago has a problem holding the Dom object type, even with an instance of pointing to its new or old version.
stloyd
commented
Jul 9, 2026
| $serialized = $ownerDocument->saveXML($this->value); | ||
| if ($ownerDocument instanceof XMLDocument) { | ||
| // @mago-ignore analysis:possibly-invalid-argument | ||
| $serialized = $ownerDocument->saveXml($this->value); |
Member
Author
There was a problem hiding this comment.
In official docs, this method is not documented, but it's visible in the official stub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2514
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security